fix(@angular/build): resolve style include paths relative to ng-package.json in unit-test builder#32674
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Mar 4, 2026
Conversation
…age.json` in unit-test builder When using the `unit-test` builder with an `ng-packagr` build target, the `styleIncludePaths` from `ng-package.json` were being used relative to the workspace root instead of the library's directory. This caused build failures when libraries specified style include paths. This change ensures that these paths are correctly resolved relative to the directory containing `ng-package.json`.
alan-agius4
added
action: review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively resolves an issue where styleIncludePaths were not correctly resolved relative to the ng-package.json file within the unit-test builder. The changes correctly implement path resolution, which is crucial for libraries specifying style include paths. The e2e test updates are a good addition to verify this fix, though some minor adjustments are needed for the test setup to function as intended.
clydin
approved these changes
Mar 4, 2026
alan-agius4
added
action: merge
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the
unit-testbuilder with anng-packagrbuild target, thestyleIncludePathsfromng-package.jsonwere being used relative to the workspace root instead of the library's directory. This caused build failures when libraries specified style include paths.This change ensures that these paths are correctly resolved relative to the directory containing
ng-package.json.