Skip to content

build: update to TypeScript 6#32654

Merged
clydin merged 1 commit intoangular:mainfrom
crisbeto:ts-6-beta
Mar 4, 2026
Merged

build: update to TypeScript 6#32654
clydin merged 1 commit intoangular:mainfrom
crisbeto:ts-6-beta

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 3, 2026 •
edited
Loading

Updates the repo to TypeScript 6 and resolves the resulting test failures.

@crisbeto crisbeto added the target: minor This PR is targeted for the next minor release label Mar 3, 2026
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Mar 3, 2026
@crisbeto crisbeto force-pushed the ts-6-beta branch 7 times, most recently from 22e6c57 to d111610 Compare March 4, 2026 07:03
@crisbeto crisbeto added the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 4, 2026
@crisbeto crisbeto marked this pull request as ready for review March 4, 2026 08:10
@crisbeto crisbeto requested a review from alan-agius4 March 4, 2026 08:10
gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 4, 2026
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully updates the project to TypeScript 6.0.0-beta and diligently addresses the resulting build and test failures. The changes are comprehensive, including dependency updates, removal of deprecated TypeScript options like baseUrl, and fixes for stricter type-checking rules such as strict property initialization. A notable improvement is the refactoring of numerous asynchronous tests to use async/await, enhancing their clarity and maintainability. The modifications appear correct and necessary for the upgrade.

Note: Security Review did not run due to the size of the PR.

@crisbeto crisbeto force-pushed the ts-6-beta branch 2 times, most recently from d33591b to 0e8c554 Compare March 4, 2026 09:07
@crisbeto crisbeto force-pushed the ts-6-beta branch 2 times, most recently from 3b880dc to f799448 Compare March 4, 2026 12:09
@crisbeto
build: update to TypeScript 6
76ecd7d 
Updates the repo to TypeScript 6 and resolves the resulting test failures.
@crisbeto
Copy link
Member Author

crisbeto commented Mar 4, 2026

Should be ready to go.

alan-agius4
alan-agius4 approved these changes Mar 4, 2026
View reviewed changes
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 4, 2026
@clydin clydin merged commit 1d7fceb into angular:main Mar 4, 2026
35 checks passed
@clydin
Copy link
Member

clydin commented Mar 4, 2026

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alan-agius4 alan-agius4 alan-agius4 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crisbeto @clydin @alan-agius4