Add Telecom Jetpack library snippets#876
Conversation
natarajkr007
commented
Apr 20, 2026
natarajkr007
commented
- Add snippets for VoIP call log exclusion
- Add snippets for handling VoIP callback intents
- Add snippets for dialer callback initiation
- Add sample dialer and VoIP app modules for Telecom
- Add core-telecom dependency and necessary permissions configuration
* Add snippets for VoIP call log exclusion * Add snippets for handling VoIP callback intents * Add snippets for dialer callback initiation * Add sample dialer and VoIP app modules for Telecom * Add core-telecom dependency and necessary permissions configuration
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces two new modules, :telecom:dialer and :telecom:voipapp, to demonstrate Jetpack Telecom features such as VoIP call log integration and callback handling. The review feedback identifies critical syntax errors in the Gradle configuration for compileSdk across both modules and the use of a non-standard API constant in a @RequiresApi annotation. Additionally, the reviewer pointed out several instances of unused variables and methods, as well as a logical inconsistency regarding the return type of a helper function in the VoIP application.
| ":cars", | ||
| ":installprompt", | ||
| ) | ||
| ":telecom:voipapp", |
There was a problem hiding this comment.
instead of adding 2 top-level modules to the snippets repo, can this just be one telecom module? (with both voipapp and dialer snippets in there) Just trying to minimize the # of new top-level modules we have, and limit it to 1 per topic area unless absolutely necessary.
There was a problem hiding this comment.
telecom library targets two different apps categories, calling and dialer. They use different APIs, hence created two different modules for better clarity.
There was a problem hiding this comment.
Creating a dedicated module still adds too much build time and there's only a single useful Kotlin file per module. Please merge them and have two separate activities
There was a problem hiding this comment.
Are we trying for better maintanance or faster builds?
* Add license headers to XML and Kotlin files in dialer and voipapp modules * Apply minor code formatting and cleanup to Kotlin files * Standardize XML declarations in resource files
* Migrate `VoipCallbackActivity` to Jetpack Compose * Remove unused XML layouts, Fragments, and ViewModels from `voipapp` * Add Compose dependencies and build features to `voipapp` * Clean up unused variables and comments in `dialer` module * Update `dialer` app name string to "Dialer" * Update `RequiresApi` level to 37 in `VoipCallbackActivity`
|
I forgot to publish my comments 🤦♂️. We'll try to follow-up in another pull request |
3 participants
