Skip to content

chore: adds broader .gitignore and packaging.yaml#39

Open
telpirion wants to merge 1 commit intomainfrom
erschmid/admin-tasks
Open

chore: adds broader .gitignore and packaging.yaml#39
telpirion wants to merge 1 commit intomainfrom
erschmid/admin-tasks

Conversation

@telpirion
Copy link
Copy Markdown
Contributor

This PR adds two new files:

  • A root-level .gitignore to help us keep the repo clean
  • A packaging.yaml file to surface these samples on DAC

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a root .gitignore file with standard Android and IntelliJ exclusions, along with a .google/packaging.yaml file for sample metadata. The review feedback suggests enhancing the .gitignore by adding .kotlin/ for build consistency and secrets.properties to prevent accidental exposure of sensitive API keys. Additionally, it was noted that several IntelliJ-specific file entries are redundant as they are already covered by the .idea/ directory exclusion.

Comment thread .gitignore
@@ -0,0 +1,36 @@
# Gradle files
.gradle/
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The .kotlin/ directory is used for caching by the Kotlin compiler and scripts. It is already ignored in several sub-directory .gitignore files within this repository (e.g., AdaptiveJetStream/.gitignore). Adding it to the root .gitignore ensures consistent behavior across the project.

.gradle/
.kotlin/

Comment thread .gitignore
build/

# Local configuration file (sdk path, etc)
local.properties
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-medium medium

It is a security best practice to ignore secrets.properties, as it is commonly used by the Google Secrets Gradle plugin to store sensitive API keys. Including it in the root .gitignore helps prevent accidental commits of sensitive information.

local.properties
secrets.properties

Comment thread .gitignore
Comment on lines +21 to +24
.idea/
misc.xml
deploymentTargetDropDown.xml
render.experimental.xml
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The entries misc.xml, deploymentTargetDropDown.xml, and render.experimental.xml are IntelliJ-specific configuration files that are typically stored within the .idea/ directory. Since .idea/ is already being ignored on line 21, these individual entries are redundant and can be removed to keep the .gitignore clean.

.idea/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant