Add worker crash recovery to ProcessParallelController#395
Open
jhewers-pf wants to merge 2 commits intoalgorithmicsuperintelligence:mainfrom
Open
Add worker crash recovery to ProcessParallelController#395jhewers-pf wants to merge 2 commits intoalgorithmicsuperintelligence:mainfrom
jhewers-pf wants to merge 2 commits intoalgorithmicsuperintelligence:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a child process in the ProcessPoolExecutor crashes (OOM, segfault, etc.), Python raises BrokenExecutor and the pool becomes unusable. Previously, this was caught as a generic Exception, logged, and caused silent failure of the evolution process.
Changes
collection, waits briefly for system stabilization, and recreates the pool
Behavior
When a worker crashes:
If 3 crashes occur without any successful iterations in between, evolution stops gracefully.