Skip to content

fix to handle "#" character in url#6

Closed
mkzol wants to merge 1 commit into
akrylysov:mainfrom
mkzol:fix-hash
Closed

fix to handle "#" character in url#6
mkzol wants to merge 1 commit into
akrylysov:mainfrom
mkzol:fix-hash

Conversation

@mkzol
Copy link
Copy Markdown

@mkzol mkzol commented May 14, 2026

the player doesn't work as expected on URL having a "#". Audio look the the left part of the first "#" character, then
Uncaught (in promise) DOMException: The media resource indicated by the src attribute or assigned media provider object was not suitable.

Fix is to fix this issue. There is surely a better way to do it

@akrylysov
Copy link
Copy Markdown
Owner

akrylysov commented May 17, 2026

Hi! Does this happen when the S3 object name contains the character? Might be happening with other special characters.

@mkzol
Copy link
Copy Markdown
Author

mkzol commented May 17, 2026

Hello, it appears indeed whenever this character in the filename.
No issue met with other characters so far.
This patch will break if the character is to be considered a property marker (https://developer.mozilla.org/en-US/docs/Web/API/URL/hash). So it should not be replaced in the general case but be handled according the situation.

@akrylysov
Copy link
Copy Markdown
Owner

Thanks for the details. I fixed the issue in this commit e2cc7b2 in a more generic way. Please let me know if it works fine for you now.

@mkzol
Copy link
Copy Markdown
Author

mkzol commented May 27, 2026

Hello, it works ! Thank you 👍

@akrylysov
Copy link
Copy Markdown
Owner

Thanks for checking!

@akrylysov akrylysov closed this May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants