Add GLM-5.2 harness support#82
Merged
Merged
Conversation
|
I have enough to finalize the review. Let me confirm the overwriting loop context once more, then record. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add GLM-5.2 support for the Z.AI Coding Plan harness, including fallback model metadata, effort mapping, and request payload coverage.
Issues addressed
zai-coding-plan/glm-5.2metadata for stale local model snapshots.low|medium|high -> high,xhigh|max -> max.reasoning_effort: max.Verified false
Not addressed
models-snapshot.ts; runtime fallback handles stale snapshots and the live models.dev entry is already present.Test plan
bun test test/provider/transform.test.ts --timeout 30000bun test test/session/llm.test.ts --timeout 30000bun test test/provider/provider.test.ts --timeout 30000bun run typecheckgit diff --checkbun turbo typecheck