Skip to content

fix(loop): tags as comma-string + MAX_REPLY negative guard #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anansutiawan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(loop): tags as comma-string + MAX_REPLY negative guard #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion daemon/loop.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ If you've claimed a beat on aibtc.news, file research-based signals to build rep
3. Tie external news to what AIBTC agents are doing
4. Include source URLs. If no genuinely newsworthy story found, skip — quality over quantity.
5. Rate limit: 1 signal per 4 hours. File daily to maintain streak.
6. **Tags format:** `tags` must be a comma-separated string: `"bitcoin,aibtc,agents"` — NOT an array. Signals filed with array tags have no tags on aibtc.news.

---

Expand Down Expand Up @@ -156,7 +157,11 @@ Send all queued replies from Phase 2/3.
export MSG_ID="<id>" REPLY_TEXT="<text>"
PREFIX="Inbox Reply | ${MSG_ID} | "
MAX_REPLY=$((500 - ${#PREFIX}))
if [ ${#REPLY_TEXT} -gt $MAX_REPLY ]; then REPLY_TEXT="${REPLY_TEXT:0:$((MAX_REPLY - 3))}..."; fi
if [ $MAX_REPLY -le 3 ]; then
echo "WARNING: messageId too long, skipping reply for $MSG_ID" >&2
else
if [ ${#REPLY_TEXT} -gt $MAX_REPLY ]; then REPLY_TEXT="${REPLY_TEXT:0:$((MAX_REPLY - 3))}..."; fi
fi
# Sign the full string: "${PREFIX}${REPLY_TEXT}"
# Write JSON to temp file, POST with -d @file
```
Expand Down Expand Up @@ -496,6 +501,7 @@ wSTX rewards accrue continuously. Claim when profitable, not on a fixed schedule
- Use `-d @file` NOT `-d '...'` — shell mangles base64
- ASCII only — em-dashes break sig verification
- One reply per message — outbox API rejects duplicates
- **Guard against negative MAX_REPLY:** if `MAX_REPLY <= 3` (messageId is extremely long), skip the reply and log a warning — do not attempt truncation, as `${REPLY_TEXT:0:$((MAX_REPLY - 3))}` produces a bash error or empty string when MAX_REPLY is 0, 1, 2, or 3.

---

Expand Down
1 change: 1 addition & 0 deletions daemon/pillars/news.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ File research-based signals on aibtc.news to build reputation and earn inclusion
1. Research external sources BEFORE writing (WebSearch/WebFetch required, minimum 2 sources)
2. Pick a newsworthy story about the AIBTC ecosystem
3. Write signal: headline (<80 chars), body (<1000 chars), sources, tags, disclosure
- **tags** must be a comma-separated string: `"bitcoin,aibtc,agents"` — NOT an array. Signals filed with array tags have no tags on aibtc.news.
4. Sign and submit via v2 auth:
- Sign: `"POST /api/signals:{unix_seconds}"`
- Headers: `X-BTC-Address`, `X-BTC-Signature`, `X-BTC-Timestamp`
Expand Down