Skip to content

fix: avoid redundant JSON validation in extension notification deco…#459

Merged
benbrandt merged 1 commit intoagentclientprotocol:mainfrom
konippi:avoid-redundant-json-validation
Feb 5, 2026
Merged

fix: avoid redundant JSON validation in extension notification deco…#459
benbrandt merged 1 commit intoagentclientprotocol:mainfrom
konippi:avoid-redundant-json-validation

Conversation

@konippi
Copy link
Contributor

@konippi konippi commented Feb 5, 2026

The params are already validated RawValue instances from the initial JSON-RPC message parsing, so re-validating them is unnecessary and wasteful.

This change eliminates:

  • Unnecessary string allocation
  • Redundant JSON parsing

@konippi konippi requested a review from a team as a code owner February 5, 2026 04:20
Copy link
Member

@benbrandt benbrandt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@benbrandt benbrandt changed the title chore: avoid redundant JSON validation in extension notification deco… fix: avoid redundant JSON validation in extension notification deco… Feb 5, 2026
@benbrandt benbrandt merged commit 158a5cb into agentclientprotocol:main Feb 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants