Conversation
yordis
left a comment
There was a problem hiding this comment.
My primary concern are,
Boolean explosion
If we add deleted, Would we add created, renamed, etc? Are we comfortable turning diff into a growing bag of flags with unclear combinations?
Explicit operation
Isn’t deleted an operation (the file’s post-state) rather than an attribute? Wouldn’t a single kind: added|modified|deleted be the more direct representation and closer to how tools like git model it?
Semantic complexity
What does deleted=true actually mean for newText and validation rules? Must newText be empty, ignored, or still applied? How do we prevent contradictory payloads like deleted=true with non-empty newText, or deleted=false with /dev/null-style semantics later?
|
I think that deleted here is only for the sake of compatibility, as we don't want to have a breaking change for a tiny fix |
@benbrandt I suppose the can do a tiny non-breaking change and after do some real fixes in the product, after we can start a new wave of discussions towards our shiny feature |
No description provided.