fix(useId): prevent FinalizationRegistry entry leak in useId#9853
Open
reidbarber wants to merge 3 commits intomainfrom
Open
fix(useId): prevent FinalizationRegistry entry leak in useId#9853reidbarber wants to merge 3 commits intomainfrom
reidbarber wants to merge 3 commits intomainfrom
Conversation
|
Build successful! 🎉 |
## API Changes
react-aria-components/react-aria-components:I18nProviderProps-I18nProviderProps {
- children: ReactNode
- locale?: string
-}/react-aria-components:Locale-Locale {
- direction: Direction
- locale: string
-}/react-aria-components:Filter-Filter {
- contains: (string, string) => boolean
- endsWith: (string, string) => boolean
- startsWith: (string, string) => boolean
-}/react-aria-components:CollectionProps-CollectionProps <T> {
- addIdAndValue?: boolean
- children?: ReactNode | (T) => ReactNode
- dependencies?: ReadonlyArray<any>
- idScope?: Key
- items?: Iterable<T>
-}/react-aria-components:Placement-Placement {
- P: undefined
-}/react-aria-components:VisuallyHiddenProps-VisuallyHiddenProps {
- children?: ReactNode
- className?: string | undefined
- elementType?: string | JSXElementConstructor<any> = 'div'
- id?: string | undefined
- isFocusable?: boolean
- role?: AriaRole | undefined
- style?: CSSProperties | undefined
- tabIndex?: number | undefined
-}/react-aria-components:ListDataOptions-ListDataOptions <T> {
- filter?: (T, string) => boolean
- getKey?: (T) => Key
- initialFilterText?: string
- initialItems?: Array<T>
- initialSelectedKeys?: 'all' | Iterable<Key>
-}/react-aria-components:TreeDataOptions-TreeDataOptions <T extends {}> {
- getChildren?: ({}) => Array<{}>
- getKey?: ({}) => Key
- initialItems?: Array<{}>
- initialSelectedKeys?: Iterable<Key>
-}/react-aria-components:AsyncListOptions-AsyncListOptions <C, T> {
- getKey?: (T) => Key
- initialFilterText?: string
- initialSelectedKeys?: Iterable<Key>
- initialSortDescriptor?: SortDescriptor
- load: AsyncListLoadFunction<T, C>
- sort?: AsyncListLoadFunction<T, C, (AsyncListLoadOptions<T, C> & {
- sortDescriptor: SortDescriptor
-})>
-}/react-aria-components:AsyncListLoadFunction-AsyncListLoadFunction {
- A: undefined
-}/react-aria-components:AsyncListLoadOptions-AsyncListLoadOptions <C, T> {
- cursor?: C
- filterText?: string
- items: Array<T>
- loadingState?: LoadingState
- selectedKeys: Selection
- signal: AbortSignal
- sortDescriptor?: SortDescriptor
-}/react-aria-components:AsyncListStateUpdate-AsyncListStateUpdate <C, T> {
- cursor?: C
- filterText?: string
- items: Iterable<T>
- selectedKeys?: Iterable<Key>
- sortDescriptor?: SortDescriptor
-}@react-spectrum/s2/@react-spectrum/s2:ComboBoxSection ComboBoxSection <T extends {}> {
aria-label?: string
children?: ReactNode | (T) => ReactElement
- className?: string = 'react-aria-ListBoxSection'
+ className?: string
dependencies?: ReadonlyArray<any>
id?: Key
items?: Iterable<T>
- render?: DOMRenderFunction<keyof React.JSX.IntrinsicElements, undefined>
style?: CSSProperties
value?: T
}/@react-spectrum/s2:ComboBoxSectionProps ComboBoxSectionProps <T extends {}> {
aria-label?: string
children?: ReactNode | (T) => ReactElement
- className?: string = 'react-aria-ListBoxSection'
+ className?: string
dependencies?: ReadonlyArray<any>
id?: Key
items?: Iterable<T>
- render?: DOMRenderFunction<keyof React.JSX.IntrinsicElements, undefined>
style?: CSSProperties
value?: T
}/@react-spectrum/s2:SortDirection-SortDirection {
- S: undefined
-}/@react-spectrum/s2:ListOptions-ListOptions <T> {
- filter?: (T, string) => boolean
- getKey?: (T) => Key
- initialFilterText?: string
- initialItems?: Array<T>
- initialSelectedKeys?: 'all' | Iterable<Key>
-}/@react-spectrum/s2:TreeOptions-TreeOptions <T extends {}> {
- getChildren?: ({}) => Array<{}>
- getKey?: ({}) => Key
- initialItems?: Array<{}>
- initialSelectedKeys?: Iterable<Key>
-}/@react-spectrum/s2:AsyncListOptions-AsyncListOptions <C, T> {
- getKey?: (T) => Key
- initialFilterText?: string
- initialSelectedKeys?: Iterable<Key>
- initialSortDescriptor?: SortDescriptor
- load: AsyncListLoadFunction<T, C>
- sort?: AsyncListLoadFunction<T, C, (AsyncListLoadOptions<T, C> & {
- sortDescriptor: SortDescriptor
-})>
-}/@react-spectrum/s2:AsyncListLoadFunction-AsyncListLoadFunction {
- A: undefined
-}/@react-spectrum/s2:AsyncListLoadOptions-AsyncListLoadOptions <C, T> {
- cursor?: C
- filterText?: string
- items: Array<T>
- loadingState?: LoadingState
- selectedKeys: Selection
- signal: AbortSignal
- sortDescriptor?: SortDescriptor
-}/@react-spectrum/s2:AsyncListStateUpdate-AsyncListStateUpdate <C, T> {
- cursor?: C
- filterText?: string
- items: Iterable<T>
- selectedKeys?: Iterable<Key>
- sortDescriptor?: SortDescriptor
-} |
snowystinger
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9852
Fixes
useIdsoFinalizationRegistryentries do not accumulate on every re-render. Previously, they would until the component was unmounted.✅ Pull Request Checklist:
📝 Test Instructions:
Unit test should cover.
🧢 Your Project: