Skip to content

fix: accept readonly array ComboBox values#10290

Open
lixiaoyan wants to merge 1 commit into
adobe:mainfrom
lixiaoyan:fix/combobox-readonly-value-type
Open

fix: accept readonly array ComboBox values#10290
lixiaoyan wants to merge 1 commit into
adobe:mainfrom
lixiaoyan:fix/combobox-readonly-value-type

Conversation

@lixiaoyan

Copy link
Copy Markdown
Contributor

Summary

Re-applies the readonly array value type support from #9741 after the ComboBox state file was moved during the package consolidation work.

The consolidated react-stately/src/combobox/useComboBoxState.ts had kept most of the change, but ValueType<'multiple'> was restored to mutable Key[]. This updates it back to readonly Key[] so controlled multiple ComboBox values can use readonly arrays.

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@snowystinger snowystinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that and creating a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants