fix: ariaHideOutside ShadowDOM#10288
Open
snowystinger wants to merge 1 commit into
Open
Conversation
|
Build successful! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
Noticed while reviewing https://github.com/adobe/react-spectrum/pull/10188/changes#diff-29dcc007b6c87955ab3959f45722c6407485d9ca430d639b4394dbc351023a17R106 that our own logic in ariaHideOutside wasn't quite right. We had a test for it, but it was passing due to some global leaks from previous tests. I've corrected the leaks as well as the logic based on the other PR.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: