chore: Improve type detection and node contains logic for shadow dom#10287
Open
snowystinger wants to merge 3 commits into
Open
chore: Improve type detection and node contains logic for shadow dom#10287snowystinger wants to merge 3 commits into
snowystinger wants to merge 3 commits into
Conversation
5 tasks
|
Build successful! 🎉 |
## API Changes
@react-aria/utils/@react-aria/utils:getOwnerDocument getOwnerDocument {
- el: Element | null | undefined
+ target?: EventTarget | null
returnVal: undefined
}/@react-aria/utils:getOwnerWindow getOwnerWindow {
- el: (Window & any) | Element | null | undefined
+ target?: EventTarget | null
returnVal: undefined
}/@react-aria/utils:isShadowRoot isShadowRoot {
- node: Node | null
+ value: unknown
returnVal: undefined
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
Attempting to pull out some portions of #10102
This PR improves the internal types for some of our helper functions, allowing us to remove some casts. It also changes the detection for nodeContains with shadowDOM slotted components.
And it also changes some of the logic around our detection of various elements to make them SSR safe and accept a wider range of input.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: