fix: add newish api getProjectNextAvailableIdentifiers#98
fix: add newish api getProjectNextAvailableIdentifiers#98purplecabbage wants to merge 3 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
Adds a new high-level wrapper method to this library for retrieving the next available project identifiers from the underlying Console SDK, along with unit test coverage and mock data to validate the behavior.
Changes:
- Add
getProjectNextAvailableIdentifiers(orgId)toLibConsoleCLI, delegating to the SDK client and using the shared spinner/logging pattern. - Extend Jest SDK mocks and add a unit test verifying the wrapper’s return value and SDK invocation.
- Add mock response data for the new API call.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
lib/index.js |
Introduces the new getProjectNextAvailableIdentifiers instance method wrapper around the Console SDK call. |
test/lib/index.test.js |
Updates SDK mock setup and adds a unit test for the new wrapper method. |
test/data-mocks.js |
Adds mock payload for projectNextAvailableIdentifiers used by the new test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…nitions test Agent-Logs-Url: https://github.com/adobe/aio-cli-lib-console/sessions/4387cfd1-c279-4b3b-a387-74db5618e96f Co-authored-by: purplecabbage <46134+purplecabbage@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
maybe add a warning in the PR description that it needs version X of the aio-lib-console and a link to the aio-lib-console PR it is dependent on? |
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: