Skip to content

fix: add newish api getProjectNextAvailableIdentifiers#98

Open
purplecabbage wants to merge 3 commits intomasterfrom
NextAvailableIdentifiers
Open

fix: add newish api getProjectNextAvailableIdentifiers#98
purplecabbage wants to merge 3 commits intomasterfrom
NextAvailableIdentifiers

Conversation

@purplecabbage
Copy link
Copy Markdown
Member

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new high-level wrapper method to this library for retrieving the next available project identifiers from the underlying Console SDK, along with unit test coverage and mock data to validate the behavior.

Changes:

  • Add getProjectNextAvailableIdentifiers(orgId) to LibConsoleCLI, delegating to the SDK client and using the shared spinner/logging pattern.
  • Extend Jest SDK mocks and add a unit test verifying the wrapper’s return value and SDK invocation.
  • Add mock response data for the new API call.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
lib/index.js Introduces the new getProjectNextAvailableIdentifiers instance method wrapper around the Console SDK call.
test/lib/index.test.js Updates SDK mock setup and adds a unit test for the new wrapper method.
test/data-mocks.js Adds mock payload for projectNextAvailableIdentifiers used by the new test.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…nitions test

Agent-Logs-Url: https://github.com/adobe/aio-cli-lib-console/sessions/4387cfd1-c279-4b3b-a387-74db5618e96f

Co-authored-by: purplecabbage <46134+purplecabbage@users.noreply.github.com>
Copy link
Copy Markdown

Copilot AI commented Apr 9, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • scarf.sh
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node ./report.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@shazron
Copy link
Copy Markdown
Member

shazron commented Apr 10, 2026

maybe add a warning in the PR description that it needs version X of the aio-lib-console and a link to the aio-lib-console PR it is dependent on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants