fix: lazy-load ora spinner to prevent MaxListenersExceededWarning#100
Open
fix: lazy-load ora spinner to prevent MaxListenersExceededWarning#100
Conversation
Calling ora() at module load time caused the ora StdinDiscarder to pipe to process.stdout immediately, adding an error event listener on every module load. Move to a lazy getter so the ora instance is only created on first use. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
dthampy
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #99
ora()was called at module load time (const spinner = require('ora')()), causing ora's internalStdinDiscarderto pipe toprocess.stdoutand register anerrorevent listener immediately on requireMaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 error listeners added to [WriteStream]getSpinner()getter that creates the ora instance only on first useTest plan
cleanStdOutstatic method continues to work correctly viagetSpinner()🤖 Generated with Claude Code