Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion locale/circuitpython.pot
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't add new translations unless you really really need to. (claude loves to add new ones) Most of these should be swappable with existing ones. The %q approach makes it easy adapt a message for your use.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do. Pushed cd142d5 — all 11 custom strings collapsed into existing pot entries (Invalid %q pin, %q init failed, DAC Device/Channel Init Error) and the redundant in-driver deinit check is gone (shared-bindings check_for_deinit already covers it). Net: zero new pot entries vs main.

Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ msgid "%q indices must be integers, not %s"
msgstr ""

#: ports/analog/common-hal/busio/SPI.c ports/analog/common-hal/busio/UART.c
#: ports/stm/common-hal/audioio/AudioOut.c
#: shared-bindings/digitalio/DigitalInOutProtocol.c
#: shared-module/busdisplay/BusDisplay.c
msgid "%q init failed"
Expand Down Expand Up @@ -889,10 +890,12 @@ msgid "Critical ROS failure during soft reboot, reset required: %d"
msgstr ""

#: ports/stm/common-hal/analogio/AnalogOut.c
#: ports/stm/common-hal/audioio/AudioOut.c
msgid "DAC Channel Init Error"
msgstr ""

#: ports/stm/common-hal/analogio/AnalogOut.c
#: ports/stm/common-hal/audioio/AudioOut.c
msgid "DAC Device Init Error"
msgstr ""

Expand Down Expand Up @@ -1541,6 +1544,7 @@ msgstr ""

#: ports/atmel-samd/common-hal/analogio/AnalogOut.c
#: ports/stm/common-hal/analogio/AnalogOut.c
#: ports/stm/common-hal/audioio/AudioOut.c
msgid "No DAC on chip"
msgstr ""

Expand Down Expand Up @@ -4049,7 +4053,7 @@ msgstr ""
msgid "output array must be contiguous"
msgstr ""

#: py/objint_mpz.c
#: py/objint_longlong.c py/objint_mpz.c
msgid "overflow converting long int to machine word"
msgstr ""

Expand Down Expand Up @@ -4162,6 +4166,10 @@ msgstr ""
msgid "rsplit(None,n)"
msgstr ""

#: ports/stm/common-hal/audioio/AudioOut.c
msgid "sample_rate must be > 0"
msgstr ""

#: shared-bindings/audiofreeverb/Freeverb.c
msgid "samples_signed must be true"
msgstr ""
Expand Down
6 changes: 6 additions & 0 deletions ports/stm/common-hal/analogio/AnalogOut.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,9 @@ typedef struct {
} analogio_analogout_obj_t;

void analogout_reset(void);

// Shared DAC peripheral handle (defined in AnalogOut.c).
// AudioOut reuses this handle for DMA-triggered DAC operation on channel 1.
#if HAS_DAC
extern DAC_HandleTypeDef handle;
#endif
Loading
Loading