Skip to content

fix: sync .git by default #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
acmore wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: sync .git by default #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions docs/config-manifest.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,6 @@ spec:
paths:
- .:/workspace
exclude:
- .git/
- node_modules/
- dist/
ports:
Expand Down Expand Up @@ -686,7 +685,6 @@ spec:
paths:
- .:/workspace
exclude:
- .git/
- vendor/
ports:
- name: grpc
Expand Down Expand Up @@ -727,8 +725,6 @@ spec:
engine: syncthing
paths:
- .:/workspace
exclude:
- .git/
ports:
- name: app
local: 8080
Expand Down
4 changes: 2 additions & 2 deletions internal/cli/init_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ spec:
if err != nil {
t.Fatalf("read .stignore: %v", err)
}
if string(got) != ".git/\n.venv/\nnode_modules/\n.DS_Store\n" {
if string(got) != ".venv/\nnode_modules/\n.DS_Store\n" {
t.Fatalf("unexpected .stignore content %q", string(got))
}
}
Expand Down Expand Up @@ -164,7 +164,7 @@ spec:
if err != nil {
t.Fatalf("read .stignore: %v", err)
}
if string(got) != ".git/\nbin/\ndist/\n.coverprofile\ncoverage.out\n.DS_Store\n" {
if string(got) != "bin/\ndist/\n.coverprofile\ncoverage.out\n.DS_Store\n" {
t.Fatalf("unexpected .stignore content %q", string(got))
}
}
Expand Down
2 changes: 1 addition & 1 deletion internal/cli/syncthing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ const (
// defaultSyncExcludes are written to a starter .stignore when one does not
// already exist. They prevent common large or noisy directories from being
// synced by default.
var defaultSyncExcludes = []string{".git/", "node_modules", "vendor", "__pycache__", ".DS_Store"}
var defaultSyncExcludes = []string{"node_modules", "vendor", "__pycache__", ".DS_Store"}

const (
largeSyncWarnThreshold = 100 * 1024 * 1024
Expand Down
5 changes: 0 additions & 5 deletions internal/config/template.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,11 @@ var builtinNames = map[string]string{

var stignorePresets = map[string][]string{
"default": {
".git/",
".venv/",
"node_modules/",
".DS_Store",
},
"python": {
".git/",
".venv/",
"__pycache__/",
".pytest_cache/",
Expand All @@ -48,23 +46,20 @@ var stignorePresets = map[string][]string{
".DS_Store",
},
"node": {
".git/",
"node_modules/",
".next/",
"dist/",
"coverage/",
".DS_Store",
},
"go": {
".git/",
"bin/",
"dist/",
".coverprofile",
"coverage.out",
".DS_Store",
},
"rust": {
".git/",
"target/",
".DS_Store",
},
Expand Down
6 changes: 3 additions & 3 deletions internal/config/template_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ func TestBuiltinTemplateLocalIgnores(t *testing.T) {
if len(patterns) == 0 {
t.Fatal("expected built-in local ignore patterns")
}
if patterns[0] != ".git/" {
if patterns[0] != ".venv/" {
t.Fatalf("unexpected first pattern %q", patterns[0])
}
if got := BuiltinTemplateLocalIgnores("./custom.yaml"); got != nil {
Expand All @@ -109,8 +109,8 @@ func TestSTIgnorePreset(t *testing.T) {
if len(patterns) == 0 {
t.Fatal("expected go preset patterns")
}
if patterns[1] != "bin/" {
t.Fatalf("unexpected go preset pattern %q", patterns[1])
if patterns[0] != "bin/" {
t.Fatalf("unexpected go preset pattern %q", patterns[0])
}
if got := STIgnorePreset("missing"); got != nil {
t.Fatalf("expected nil for unknown preset, got %+v", got)
Expand Down
Loading