[mlir][dxsa] Add raster instructions#202
Conversation
| @@ -0,0 +1,210 @@ | |||
| //===- DXSADoubleRasterOps.td - DXSA raster ops -*- tablegen -*-===// | |||
There was a problem hiding this comment.
| //===- DXSADoubleRasterOps.td - DXSA raster ops -*- tablegen -*-===// | |
| //===- DXSARasterOps.td - DXSA raster ops -*- tablegen -*-===// |
There was a problem hiding this comment.
With the latest PRs, I've introduced a new approach to test files that was approved by Anton.
Can we combine all deriv-related tests to a single test file raster_ops.test and run mlir-translate with --split-input-file option?
atomic_ops.test
// RUN: mlir-translate --split-input-file --import-dxsa-hex %s | FileCheck %s
// RUN: mlir-translate --split-input-file --import-dxsa-hex %s | mlir-opt --split-input-file --verify-roundtrip
// CHECK-LABEL: dxsa.module {
// CHECK-NEXT: dxsa.atomic_and u<0>, r<0>, r<1, <x>>
// CHECK-NEXT: }
0x070000a9, 0x0011e000, 0x00000000, 0x00100e46, 0x00000000, 0x0010000a, 0x00000001
// -----
// CHECK-LABEL: dxsa.module {
// CHECK-NEXT: dxsa.atomic_and g<0>, r<2>, r<3, <x>>
// CHECK-NEXT: }
0x070000a9, 0x0011f000, 0x00000000, 0x00100e46, 0x00000002, 0x0010000a, 0x00000003There was a problem hiding this comment.
Notice that all latest PRs use .test extension for test files.
Refer #180 for more details.
There was a problem hiding this comment.
Unified the test, but now there's so much cases there, is that okay?
|
|
||
| // CHECK: dxsa.module { | ||
|
|
||
| // CHECK-NEXT: dxsa.deriv_rtx_coarse r<0>, v<1> |
There was a problem hiding this comment.
Suggestion (non-blocking): add a precise case for each of instructions. Base operation already supports it, but a hex line with the precise modifier would confirm the full import path for these ops.
deriv_rtx/y_coarse and deriv_rtx/y_fine instructions|
I'm still not sure if |
Add instructions:
deriv_rtxderiv_rtyderiv_rtx_coarsederiv_rty_coarsederiv_rtx_finederiv_rty_finelod