Allow proxy to auto-assign free ports for sessions#1
Open
paddybyers wants to merge 1 commit into
Open
Conversation
Make the `port` field optional in POST /sessions. When omitted or set to 0, the proxy binds to an OS-assigned free port, eliminating the TOCTOU race where callers had to guess available ports. Existing callers that pass an explicit port are unaffected. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
portfield optional inPOST /sessions. When omitted or set to0, the proxy binds to an OS-assigned free port vianet.Listen("tcp", ":0").Changes
listener.go:StartSessionListenerreturns(int, error), extracts actual port from listener address, setssession.Portunder mutex.server.go: Validation changed fromport <= 0toport < 0. Uses returnedactualPortfor response and logging.session.go: AddedomitemptytoCreateSessionRequest.Portjson tag.docs/API.md:portdocumented as optional with auto-assign behavior.proxy_test.go: Updated validation test for negative port; addedTestSessionAutoPort.Test plan
go build ./...compiles cleanlygo test ./...— all 27 tests passTestSessionAutoPortverifies auto-assigned port is valid and listening🤖 Generated with Claude Code