fix: use MySQL compatible syntax in list tasks#651
Merged
Conversation
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
ishymko
force-pushed
the
ishymko/1.0-tests
branch
from
7722cb7 to
d5818e5
Compare
ishymko
force-pushed
the
ishymko/1.0-tests
branch
from
3c7bbcd to
4d90a44
Compare
1 task
Based on [`unit-tests.yml`](https://github.com/a2aproject/a2a-python/blob/main/.github/workflows/unit-tests.yml). Supports: - `--debug` to start DB(s) without running tests (for selective running in IDE) - `--mysql`, `--postgres` to use only one DB - `--stop` to stop after running with `--debug` From project root: ```bash ./scripts/run_integration_tests.sh ``` Re #652 to troubleshoot failures
ishymko
force-pushed
the
ishymko/1.0-tests
branch
from
4d90a44 to
5ebeb51
Compare
ishymko
changed the title
This reverts commit 9dad851127995fb92860febef7deadc0ad79e294.
ishymko
force-pushed
the
ishymko/1.0-tests
branch
from
5ebeb51 to
4a1e918
Compare
ishymko
changed the title
guglielmo-san
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Do not use
NULLS LASTwhich is not available in MySQL, coalesce nulls to empty strings which will appear last in descending ordering (there are tests for this behavior already, however CI wasn't enabled for this branch).Currently
NULLS LASTfails MySQL tests:(actions run)
Enable tests run against
1.0-devto prevent it in the future.Re #511
Fixes #652
Mark as "refactor" for release please as it's a fix for a non-released feature, hence shouldn't get into a changelog.
BEGIN_COMMIT_OVERRIDE
refactor: use MySQL compatible syntax in list tasks
END_COMMIT_OVERRIDE