feat: module 01 & 02 — models extraction, bug fixes, tests, custom prompts#15
Open
konradjerrybarrek wants to merge 4 commits intoYvFrey:mainfrom
Open
feat: module 01 & 02 — models extraction, bug fixes, tests, custom prompts#15konradjerrybarrek wants to merge 4 commits intoYvFrey:mainfrom
konradjerrybarrek wants to merge 4 commits intoYvFrey:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary:
feat/01→mainWhat changed
app/models.py— new fileExtracted all Pydantic models (
TaskStatus,DeveloperTask,ProductivityReport) frommain.pyinto a dedicated models file, satisfying the mandatory coding guideline requiring models to live inapp/models.py.app/main.py— refactored & bug fixesapp.modelsinstead of defining them inlinegenerate_productivity_reportwas countingPENDINGtasks as completed — now correctly countsCOMPLETEget_statusconverted toasync defwith explicit-> dictreturn typelog_tasknow returns aDeveloperTaskmodel (was returning an f-string), usesmodel_copyfor immutable update, and hasresponse_modelon the decoratorGET /task/{task_id}/statusendpointtests/— new test suitetests/conftest.py: shared asyncclientfixture usinghttpx.AsyncClient+ASGITransporttests/unit/test_main.py: 8 unit tests coveringfetch_all_tasksandgenerate_productivity_reporttests/integration/test_main.py: 10 integration tests covering all endpoints (happy path, validation errors, model validation).github/prompts/— new custom promptlogs-audit.prompt.md: reusable/logs-auditprompt for production logging reviews