docker: use host network to allow same MAC as host#144
Open
taraxacum45e9a wants to merge 1 commit into
Open
Conversation
ecdce06 to
4cc5dc3
Compare
Signed-off-by: Shen Jiamin <shen_jiamin@comp.nus.edu.sg>
4cc5dc3 to
76df5e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When building the static shell or dcmac example via
scripts/run-with-docker.sh, a license file is mounted into the container. If the license is node-locked (tied to the host's MAC address), Vivado rejects it because the container's network interface has a different MAC address than the host's — even though the mounted license file is valid.Fix
Add
--network hostto the docker run args wheneverSLASH_LICENSE_PATHis set. This makes the container share the host's network namespace (and thus its MAC address), so Vivado correctly recognizes node-locked licenses.close #137