Skip to content

PHP 8.6: Add polyfills for clamp and ValueError functions for PHP compatibility#11669

Open
Soean wants to merge 1 commit intoWordPress:trunkfrom
Soean:65143
Open

PHP 8.6: Add polyfills for clamp and ValueError functions for PHP compatibility#11669
Soean wants to merge 1 commit intoWordPress:trunkfrom
Soean:65143

Conversation

@Soean
Copy link
Copy Markdown
Member

@Soean Soean commented Apr 28, 2026

This pull request adds a polyfill for the new PHP 8.6 clamp() function to ensure compatibility with older PHP versions. It also introduces a helper function to throw the appropriate error type depending on the PHP version.

New function polyfills and helpers:

  • Added _wp_throw_value_error() to throw a ValueError on PHP 8.0+ or an InvalidArgumentException on PHP 7.x, providing consistent error handling for polyfills.
  • Added a polyfill for the clamp() function, which restricts a value within a specified minimum and maximum, including input validation and appropriate error throwing for invalid arguments.

Trac ticket: https://core.trac.wordpress.org/ticket/65143

Use of AI Tools

AI assistance: Yes
Tool(s): GitHub Copilot
Model(s): Claude Opus 4.6
Used for: Code docs.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props soean.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Soean Soean changed the title Add polyfills for clamp and ValueError functions for PHP compatibility PHP 8.6: Add polyfills for clamp and ValueError functions for PHP compatibility Apr 28, 2026
@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

*
* Helper for polyfills that need to throw ValueError but must also run on PHP 7.4.
*
* @ignore
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ignore?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants