Exclude php-api-client from PHPStan analysis#11150
Closed
westonruter wants to merge 2 commits intoWordPress:trunkfrom
Closed
Exclude php-api-client from PHPStan analysis#11150westonruter wants to merge 2 commits intoWordPress:trunkfrom
westonruter wants to merge 2 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
pento
pushed a commit
that referenced
this pull request
Mar 4, 2026
…tream. Third-party paths are also re-sorted in the PHPStan config. Developed in #11150 Follow up to r61776, r61712, r61699. Props justlevine, flixos90, westonruter. See #64591, #61175. git-svn-id: https://develop.svn.wordpress.org/trunk@61808 602fd350-edb4-49c9-b593-d223f7449a82
Member
Author
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Mar 4, 2026
…tream. Third-party paths are also re-sorted in the PHPStan config. Developed in WordPress/wordpress-develop#11150 Follow up to r61776, r61712, r61699. Props justlevine, flixos90, westonruter. See #64591, #61175. Built from https://develop.svn.wordpress.org/trunk@61808 git-svn-id: http://core.svn.wordpress.org/trunk@61108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #10990 (r61712). The library update in r61776 re-introduced the following PHPStan issues which had previously been fixed:
I wasn't fully aware that
src/wp-includes/php-ai-clientis all a third party library pulled in from another source, not justsrc/wp-includes/php-ai-client/third-party. So in 6aee2e5 the former path is excluded instead.This also re-sorts the paths for third-party libraries in 56b149f.
Trac ticket: https://core.trac.wordpress.org/ticket/64591
Use of AI Tools
n/a
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.