Skip to content

Increase color picker button height #11093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hmbashar wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Increase color picker button height #11093

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a0dd55
Increase color picker button height
hmbashar Feb 28, 2026
a3e1e98
corraction line height and adjust the space
hmbashar Feb 28, 2026
7d133ea
adjust height
hmbashar Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/wp-admin/css/color-picker.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

/* Needs higher specificity to override `.wp-core-ui .button`. */
.wp-picker-container .wp-color-result.button {
min-height: 30px;
min-height: 40px;
margin: 0 6px 6px 0;
padding: 0 0 0 30px;
font-size: 11px;
Expand All @@ -23,7 +23,7 @@
color: #50575e;
display: block;
line-height: 2.54545455; /* 28px */
padding: 0 6px;
padding: 5px 6px;
Comment on lines 25 to +26
Copy link
Contributor

@t-hamano t-hamano Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the two lines here are contradictory. Based on the implementation so far, I think the element height should be determined only by the line-height value. The expected element height here is 38px and the font size is 11px, so the line-height value can be calculated using the following formula:

38 / 11 = 3.454545454545455

.wp-picker-container .wp-color-result.button {
	line-height:  3.45454545; /* 38px */
	padding: 0 6px;
}

text-align: center;
}

Expand Down Expand Up @@ -77,7 +77,7 @@
margin-left: 6px;
padding: 0 8px;
line-height: 2.54545455; /* 28px */
Copy link
Contributor

@t-hamano t-hamano Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
line-height: 2.54545455; /* 28px */
line-height: 3.45454545; /* 38px */

The expected element height here is 38px and the font size is 11px, so the line-height value can be calculated using the following formula:

38 / 11 = 3.454545454545455

Copy link
Author

@hmbashar hmbashar Mar 2, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worked on it, but @mukeshpanchal27 requested changes. After that, I restored the line and used padding.
check above conversation.

min-height: 30px;
min-height: 40px;
}

.wp-picker-container .iris-square-slider .ui-slider-handle:focus {
Expand All @@ -98,7 +98,7 @@
margin: 0;
padding: 0 5px;
vertical-align: top;
min-height: 30px;
min-height: 40px;
}

.wp-color-picker::-webkit-input-placeholder {
Expand Down
Loading