Skip to content

Fix PHPStan rule level 0 errors in php-ai-client #10990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
westonruter wants to merge 1 commit into from
+1 −3
Closed

Fix PHPStan rule level 0 errors in php-ai-client #10990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/wp-includes/php-ai-client/src/Providers/Http/Enums/RequestAuthenticationMethod.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ class RequestAuthenticationMethod extends AbstractEnum
* @since 0.4.0
*
* @return class-string<RequestAuthenticationInterface&WithArrayTransformationInterface> The implementation class.
*
* @phpstan-ignore missingType.generics
*/
public function getImplementationClass(): string
{
Expand Down
1 change: 0 additions & 1 deletion src/wp-includes/php-ai-client/src/Providers/Http/HttpTransporter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,6 @@ private function convertFromPsr7Response(ResponseInterface $psr7Response): Respo
return new Response(
$psr7Response->getStatusCode(),
$psr7Response->getHeaders(),
// @phpstan-ignore-line
$body === '' ? null : $body
);
}
Expand Down
1 change: 1 addition & 0 deletions tests/phpstan/base.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,3 +138,4 @@ parameters:
- ../../src/wp-includes/SimplePie
- ../../src/wp-includes/sodium_compat
- ../../src/wp-includes/Text
- ../../src/wp-includes/php-ai-client/third-party
Copy link

@justlevine justlevine Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@westonruter @felixarntz should the entire php-ai-client directory be ignored by PHPStan?

I think from the perspective of wordpress-core the entire php-ai-client is external, and while I'm not sure if syncs like #11102 are manual or automatic, I'd assume we don't want to keep clobbering them back into the codebase

Copy link
Member Author

@westonruter westonruter Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justlevine wanna open a PR?

Copy link
Member Author

@westonruter westonruter Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm opening one. There are currently 2,489 errors errors in trunk 😬

Copy link
Member Author

@westonruter westonruter Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or no, sorry, that was my stale cache apparently.

Copy link
Member Author

@westonruter westonruter Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #11150

Loading