-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Trac 64389: Refine hoisted stylesheet ordering in classic themes #10875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
westonruter
wants to merge
24
commits into
WordPress:trunk
Choose a base branch
from
westonruter:trac-64389
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+398
−118
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
ded6e2e
Add failing test case to capture the Elementor scenario
westonruter 485549b
Add global-styles placeholder which is replaced during hoisting
westonruter ec819ad
Add test case for blockless theme without theme.json
westonruter 2f8713c
Ensure global styles placeholder is removed even when there is no glo…
westonruter 2282411
Use actual CSS instead of comment in case a minifier tries to strip o…
westonruter b7b1740
Remove obsolete conditions for inserting global-styles
westonruter 4f99b7d
Refine comment copy
westonruter 45ec7f4
Update return tag for data provider to reflect new array shape
westonruter ff8cbc1
Fix priority in comment regarding wp_custom_css_cb()
westonruter 48eb4f6
Preserve CSS cascade so wp-block-library inline styles appear after i…
westonruter 062fdad
Merge branch 'trunk' of https://github.com/WordPress/wordpress-develo…
westonruter 75eb70a
Merge branch 'trunk' into trac-64389
westonruter 2cf0787
Leverage HTML Tag Processor in test
westonruter 6b5633d
Use HTML Tag Processor to safely construct STYLE tag
westonruter 80472f0
Add conditional return types and remove redundant param type for has_…
westonruter 0c0f529
Fix PHPStan level 8 issues in wp_hoist_late_printed_styles()
westonruter c82418b
Address PHPStan issues with test_wp_hoist_late_printed_styles
westonruter e72fc45
Clarify comment
westonruter d54326f
Eliminate looking for classic-theme-styles in favor of adding placeho…
westonruter c09f349
Remove obsolete references to classic-theme-styles
westonruter 59bdc8d
Fix grammatical typo in comment
westonruter ddcb748
Account for possibility of no sourceURL comment being present
westonruter 87a5ccb
Improve grammar in comment
westonruter 17443f4
Remove arg from being passed needlessly to assert closure
westonruter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in this file I don't intend to commit as part of this PR. They belong in a PR for Core-64238. Nevertheless, I added the changes here to ensure all of the new code introduced as part of
wp_hoist_late_printed_styles()is fully passing PHPStan rule level 8.