Conversation
closes #97
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
============================================
- Coverage 92.30% 92.12% -0.18%
- Complexity 1265 1268 +3
============================================
Files 39 39
Lines 3042 3049 +7
============================================
+ Hits 2808 2809 +1
- Misses 234 240 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
When
WebServicesManageris used within the WebFiori framework, it now usesApp::getResponse()instead of creating its ownResponseinstance. This ensures middleware-added headers (e.g.Set-CookiefromStartSessionMiddleware) are included in API responses.Motivation
Middleware headers were lost because the API manager and the framework used separate
Responseobjects. Session cookies set bystart-sessionmiddleware never reached the client on API routes. Fixes #97.Changes
WebServicesManager::__construct()to check ifApp::getResponse()is available and use it as the shared response objectnew Response()for standalone usage outside the frameworkHow to Test / Verify
start-sessionmiddleware to the routeSet-Cookieheader is present in the responseBreaking Changes and Migration Steps
None. Standalone usage of the HTTP library is unaffected — it falls back to creating its own
Responsewhen the framework is not present.Checklist
Related issues
Closes #97