Skip to content

[NFC] revert msvc exclusion in wasm-type-printing #8706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Changqing-JING wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Draft

[NFC] revert msvc exclusion in wasm-type-printing #8706

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2df641
[NFC] revert msvc exclusion in wasm-type-printing
Changqing-JING May 13, 2026
9090260
Fix
Changqing-JING May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/wasm-type-printing.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@ template<typename Subclass> struct TypeNameGeneratorBase {

private:
constexpr void assertValidUsage() {
// This check current causes a crash on MSVC
// TODO: Convert to C++20 requires check
#if !defined(_MSC_VER) && (!defined(__GNUC__) || __GNUC__ >= 14)
// The check need MSVC 18.6.0+, otherwise it will cause compiler crash.
#if (!defined(__GNUC__) || __GNUC__ >= 14)
// Check that the subclass provides `getNames` with the correct type.
using Self = TypeNameGeneratorBase<Subclass>;
static_assert(
Expand Down
Loading