Draft
Conversation
When comparing two logged struct or array values, look up their closest public supertypes. If these supertypes are different, then the values are observably different. Otherwise, look at the fields the shared public supertype makes visible and recursively check for differences. Since GC data may in general be recursive, naively recursing may cause the comparison to exhaust the stack or fail to terminate. Instead, perform a coinductive equality check where pairs of values are assumed to be equivalent until proven otherwise. This avoids recursing into the comparison of a pair of values we have already started comparing. Since two execution traces typically differ only when the fuzzer finds a misoptimization, add a new gtest file to test the new comparison logic.
Member
Author
|
There is a known issue with this where unsubtyping makes makes it so a private subtype of a public type is no longer a subtype of that public type, which causes the comparison to fail. It seems we need to record the static type with which each particular value was exposed rather than using public supertypes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When comparing two logged struct or array values, look up their closest public supertypes. If these supertypes are different, then the values are observably different. Otherwise, look at the fields the shared public supertype makes visible and recursively check for differences. Since GC data may in general be recursive, naively recursing may cause the comparison to exhaust the stack or fail to terminate. Instead, perform a coinductive equality check where pairs of values are assumed to be equivalent until proven otherwise. This avoids recursing into the comparison of a pair of values we have already started comparing.
Since two execution traces typically differ only when the fuzzer finds a misoptimization, add a new gtest file to test the new comparison logic.