Fix TypeMapper::getNewHeapType() on types being rebuilt#8499
Open
kripken wants to merge 2 commits intoWebAssembly:mainfrom
Open
Fix TypeMapper::getNewHeapType() on types being rebuilt#8499kripken wants to merge 2 commits intoWebAssembly:mainfrom
kripken wants to merge 2 commits intoWebAssembly:mainfrom
Conversation
tlively
approved these changes
Mar 19, 2026
| ;; CHECK-NEXT: (local $t (ref null $contD)) | ||
| ;; CHECK-NEXT: ) | ||
| (func $use-rec-group | ||
| (local $t (ref null $contD)) |
Member
There was a problem hiding this comment.
It would be good to add a use for each original type so we can see in the output exactly what type it was merged with, if any.
tlively
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we find a type in the mapping, we still need to get its temp type,
as it may be in the process of being rebuilt.
Not sure why it took continuations to find this bug, but something in
their shape I guess..?