Validate the use of shared types #8302
Open
+91
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We started validating that shared-everything is enabled when we defined shared types in #8298, but this missed the case where a non-shared type definition used a shared abstract heap type, which has no definition. Update the validation to check that the used types are allowed by the enabled feature set as well. Refactor the validation logic into several functions to avoid duplication of logic.
kripken
approved these changes
Feb 11, 2026
| return TypeBuilder::ErrorReason::InvalidSharedType; | ||
| } | ||
| } | ||
| return std::nullopt; |
Member
There was a problem hiding this comment.
Suggested change
| return std::nullopt; | |
| return {}; |
Member
Author
There was a problem hiding this comment.
We had a rash of CI issues a while ago that were fixed by replacing {} with std::nullopt, so now I generally use the latter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We started validating that shared-everything is enabled when we defined shared types in #8298, but this missed the case where a non-shared
type definition used a shared abstract heap type, which has no definition. Update the validation to check that the used types are allowed by the enabled feature set as well. Refactor the validation logic into several functions to avoid duplication of logic.