-
Notifications
You must be signed in to change notification settings - Fork 838
Add a pass to remove relaxed SIMD instructions #8300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
and replace them with unreachables. This might be useful in situations where a module needs to be processed by tools that do not support relaxed SIMD, but where the relaxed SIMD usage also does not affect the output of the tool.
src/passes/RemoveRelaxedSIMD.cpp
Outdated
|
|
||
| std::unique_ptr<Pass> create() { | ||
| return std::make_unique<RemoveRelaxedSIMD>(); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By convention we put these at the top (under the parallel bit)
| (i32x4.relaxed_trunc_f32x4_s (local.get 0)) | ||
| ) | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please test a case where a child must be kept around due to effects.
kripken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm otherwise
and replace them with unreachables. This might be useful in situations
where a module needs to be processed by tools that do not support
relaxed SIMD, but where the relaxed SIMD usage also does not affect the
output of the tool.