Skip to content

Add comments to dataflow.h after #8282 [NFC] #8299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 1 commit into from
Feb 11, 2026
+9 −6
Merged

Add comments to dataflow.h after #8282 [NFC] #8299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/dataflow/graph.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,8 +615,11 @@ struct Graph : public UnifiedExpressionVisitor<Graph, Node*> {
}

// Merge local state for an if, also creating a block and conditions.
void mergeIf(Locals& aState,
Locals& bState,
// ifTrueState is the state if the condition is true, while otherState is
// the state otherwise (either from before the if, if there is no other arm,
// or the else arm if there is).
void mergeIf(Locals& ifTrueState,
Locals& otherState,
Node* condition,
Expression* expr,
Locals& out) {
Expand All @@ -635,11 +638,11 @@ struct Graph : public UnifiedExpressionVisitor<Graph, Node*> {
}
// Finally, merge the state with that block. TODO optimize
std::vector<FlowState> states;
if (!isInUnreachable(aState)) {
states.emplace_back(aState, ifTrue);
if (!isInUnreachable(ifTrueState)) {
states.emplace_back(ifTrueState, ifTrue);
}
if (!isInUnreachable(bState)) {
states.emplace_back(bState, ifFalse);
if (!isInUnreachable(otherState)) {
states.emplace_back(otherState, ifFalse);
}
merge(states, out);
}
Expand Down