Conversation
sbc100
force-pushed
the
cxx20
branch
2 times, most recently
from
5973b98 to
86d1856
Compare
Member
Author
|
Is it time? |
Member
|
Sounds good to me. I wonder what's up with ICE in wasm-type-printer.h. Maybe try removing |
Member
|
See #6060 (comment) from @dschuff about c++20 |
Member
|
Yeah, that's something to look into. Also it looks like there are some other gcc-isms like the |
sbc100
added a commit
that referenced
this pull request
Mar 30, 2026
This matches the C++20 API that we cannot quite use yet. At least not until #8218 lands.
sbc100
added a commit
that referenced
this pull request
Mar 30, 2026
This matches the C++20 API that we cannot quite use yet. At least not until #8218 lands.
sbc100
force-pushed
the
cxx20
branch
2 times, most recently
from
91760b9 to
e29758c
Compare
sbc100
added a commit
that referenced
this pull request
Mar 30, 2026
This matches the C++20 API that we cannot quite use yet. At least not until #8218 lands.
sbc100
added a commit
that referenced
this pull request
Mar 30, 2026
This matches the C++20 API that we cannot quite use yet. At least not until #8218 lands.
sbc100
added a commit
that referenced
this pull request
Mar 30, 2026
This matches the C++20 API that we cannot quite use yet. At least not until #8218 lands.
kripken
approved these changes
Mar 30, 2026
As a test I converted all the `set::count` calls to `set::contains` when they were used for membership testing.
tlively
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a test I converted all the
set::countcalls toset::containswhenthey were used for membership testing.