Open
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| await web3auth.logout(); | ||
|
|
||
| if (!web3auth.connected) { | ||
| setProvider(null); |
There was a problem hiding this comment.
Missing await on getAddress() in getBalance
Medium Severity
In getBalance, signer.getAddress() is called without await, while getAccounts correctly uses await signer.getAddress(). The signer state is set via an as Wallet force-cast from web3auth.signer. If the actual runtime object is a generic Signer rather than a Wallet, getAddress() returns a Promise<string>, and passing that Promise to signer.provider?.getBalance(address) would fail to resolve the correct balance.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Jira Link:
Description
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Note
Medium Risk
Changes how the demo initializes Web3Auth and performs RPC/signing, plus replaces Metro polyfill configuration; regressions are most likely in bundling/startup or runtime balance/address fetching, but scope is limited to the example app.
Overview
Updates the
rn-bare-aggregate-verifier-exampledemo to use Web3Auth’ssignerdirectly (removing theEthereumPrivateKeyProvider/chain config setup andprovider-basedethers.BrowserProviderflow) and rewires account/balance/signing calls to operate on the storedWalletsigner.Standardizes React Native app bootstrap and bundler setup by importing
@web3auth/react-native-sdk/setupfirst inindex.jsand replacing custom Metro polyfill/module mappings withwithWeb3Auth(defaultConfig)inmetro.config.js.Written by Cursor Bugbot for commit 191c535. This will update automatically on new commits. Configure here.