Open
Conversation
arch1995
reviewed
Aug 26, 2025
arch1995
reviewed
Aug 26, 2025
src/Web3Auth.ts
Outdated
| this.options.authConnectionConfig ?? [], | ||
| "authConnectionId" | ||
| ); | ||
| this.options.mfaSettings = merge(clonedeep(this.projectConfig.mfaSettings), this.options.mfaSettings); |
Contributor
There was a problem hiding this comment.
We should merge other settings as well here - like sessionTime, userDataInIdToken, mfa settings etc.
Can refer to no-modal sdk as well to check how the config from the user and config from the apis are merged
Member
Author
There was a problem hiding this comment.
@arch1995 i updated other fields
for sessionTime and includeUserDataInToken already has default value in constructor
if (!options.sessionTime) options.sessionTime = 86400;
if (typeof options.enableLogging === "undefined") options.enableLogging = false;
if (options.enableLogging) {
log.setLevel("debug");
} else {
log.setLevel("ERROR");
}
if (typeof options.includeUserDataInToken === "boolean") options.includeUserDataInToken = true;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
v10 upgrade
Jira Link: https://consensyssoftware.atlassian.net/browse/W3APD-4992
Description
Use auth service v10, WS v5
Update init options
Handle v2 project config
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: