feat: include refreshToken in manage-mfa redirect urlParams#397
Closed
feat: include refreshToken in manage-mfa redirect urlParams#397
Conversation
Contributor
Author
|
We should not include |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
Description
This PR includes
refreshTokenin the loginConfig data, encrypted and stored in the session server.The reason is when user tries to manage MFA in dashboard, we only store the
accessTokenin the session server, which is only sufficient to use within the accessToken valid window. After the accessToken is expired, the user in dashboard has no way to refresh the session and being logout (StorageManager, SessionManger were cleared too).How has this been tested?
Screenshots (if appropriate)
Types of changes
Checklist
Note
Medium Risk
Adds
refreshTokento themanageMFArequest payload that gets stored in the session server, expanding handling of sensitive credentials and increasing blast radius if storage/encryption or access controls are misconfigured. Functional scope is small and localized to the MFA management flow.Overview
Updates the
manageMFAflow to persist the currentrefreshTokenalongsideaccessToken/sessionIdby addingrefreshTokentoAuthRequestPayloadand populating it fromsessionManager.getRefreshToken()before storing the payload.Also bumps the Vue example to
@web3auth/auth11.4.3and refreshespackage-lock.jsonmetadata (several dependencies marked aspeer).Reviewed by Cursor Bugbot for commit e5c9d41. Bugbot is set up for automated code reviews on this repo. Configure here.