update the just file to not fail CI#6
Conversation
--- updated-dependencies: - dependency-name: fire dependency-version: 0.7.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: python-packages - dependency-name: pandas dependency-version: 3.0.2 dependency-type: direct:production update-type: version-update:semver-major dependency-group: python-packages - dependency-name: poethepoet dependency-version: 0.44.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: python-packages - dependency-name: pytest dependency-version: 9.0.3 dependency-type: direct:development update-type: version-update:semver-major dependency-group: python-packages - dependency-name: myst-nb dependency-version: 1.4.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: python-packages - dependency-name: pydata-sphinx-theme dependency-version: 0.17.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: python-packages - dependency-name: sphinx dependency-version: 9.1.0 dependency-type: direct:development update-type: version-update:semver-major dependency-group: python-packages - dependency-name: black dependency-version: 26.3.1 dependency-type: direct:development update-type: version-update:semver-major dependency-group: python-packages - dependency-name: isort dependency-version: 8.0.1 dependency-type: direct:development update-type: version-update:semver-major dependency-group: python-packages - dependency-name: jupyterlab dependency-version: 4.5.6 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: python-packages - dependency-name: jupyterlab-code-formatter dependency-version: 3.0.3 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: python-packages - dependency-name: jupytext dependency-version: 1.19.1 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: python-packages - dependency-name: setuptools dependency-version: 82.0.1 dependency-type: direct:development update-type: version-update:semver-major dependency-group: python-packages - dependency-name: setuptools-scm dependency-version: 10.0.5 dependency-type: direct:development dependency-group: python-packages ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
Pull request overview
Updates project tooling to align justfile environment sync with uv dependency groups and refreshes the dependency set/lockfile so CI/pre-commit can run successfully.
Changes:
- Switch
justfileenv/syncfromuv sync --extra ...touv sync --group .... - Update
pyproject.tomldependency minimums and regenerateuv.lockaccordingly. - Adjust Sphinx config by removing
pydata_sphinx_themefrom theextensionslist (theme remains configured viahtml_theme).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
justfile |
Uses uv dependency groups (--group) instead of extras for environment sync. |
pyproject.toml |
Bumps dependency minimum versions across runtime/dev/docs/notebooks groups. |
uv.lock |
Regenerated lockfile reflecting new versions and resolution markers. |
docs/src/conf.py |
Removes pydata_sphinx_theme from Sphinx extensions (theme still set via html_theme). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Create and sync the local uv environment with all project dependency groups. | ||
| env: | ||
| uv sync --extra dev --extra docs --extra featurization | ||
| uv sync --group dev --group docs --group notebooks | ||
|
|
||
| # Re-sync environment after dependency changes. | ||
| sync: | ||
| uv sync --extra dev --extra docs --extra featurization | ||
| uv sync --group dev --group docs --group notebooks |
There was a problem hiding this comment.
sync/env installs the notebooks dependency group (jupyterlab, etc.), but none of the targets executed by just all (lint/test/coverage/docs) appear to require those heavy notebook-only dependencies. Pulling them into the default CI/pre-commit path can significantly increase install time and introduce extra platform-specific resolution risk. Consider limiting env/sync to the groups actually needed for all (e.g., dev+docs), and add a separate recipe for notebook tooling when required.
| @@ -17,30 +17,30 @@ classifiers = [ | |||
| "Programming Language :: Python :: 3.14", | |||
| ] | |||
| dependencies = [ | |||
| "fire>=0.7", | |||
| "fire>=0.7.1", | |||
| "jinja2>=3.1.6", | |||
| "pandas>=2.2.3", | |||
| "pandas>=3.0.2", | |||
| ] | |||
| scripts.ZedProfiler = "ZedProfiler.cli:trigger" | |||
|
|
|||
| [dependency-groups] | |||
| dev = [ | |||
| "poethepoet>=0.34", | |||
| "pytest>=8.3.5", | |||
| "poethepoet>=0.44.0", | |||
| "pytest>=9.0.3", | |||
| "pytest-cov>=5", | |||
| "ruff>=0.15.10", | |||
| ] | |||
| docs = [ | |||
| "myst-nb>=1.2", | |||
| "pydata-sphinx-theme>=0.16.1", | |||
| "sphinx>=8.2.3", | |||
| "myst-nb>=1.4.0", | |||
| "pydata-sphinx-theme>=0.17.0", | |||
| "sphinx>=9.1.0", | |||
There was a problem hiding this comment.
The PR title/description is about updating the justfile to fix CI, but this change set also bumps multiple core/runtime and dev/doc dependencies (and will cascade into a large uv.lock rewrite). If the dependency upgrades are not required to fix the CI failure, it would be safer to keep this PR focused on the justfile change and land dependency bumps separately (so regressions are easier to bisect).
|
Merging PR based on checks passing |
Description
update the just file to not fail CI
What kind of change(s) are included?
Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.