Fix/issue 5088 carousel fractional row#5190
Open
biubiukam wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
fix #5088
💡 Background and solution
When
TableCarouselAnimationPluginuses a fractional row step such asrowCount: 1.5, the animated scroll target should preserve the fractional row offset. However,scrollToRowrounded the target row down before starting the animation, and the post-animation correction also snapped the final scroll position back to an integer row. This caused fractional carousel scrolling to behave incorrectly.This change keeps fractional row targets for animated
scrollToRowcalls and only applies the post-animation integer correction when the requested row is already an integer. Non-animatedscrollToRowcalls still align to an integer row.A regression test was added for
scrollToRow(1.5, animationOption)to ensure the fractional target is passed to the animation manager without scheduling an integer snap-back.📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough