Skip to content

feat(startup): add --raise-fd-limit CLI flag to raise file descriptor soft limit #277

Open
vparfonov wants to merge 1 commit into
ViaQ:v0.54.0-rhfrom
vparfonov:log9396
Open

feat(startup): add --raise-fd-limit CLI flag to raise file descriptor soft limit #277
vparfonov wants to merge 1 commit into
ViaQ:v0.54.0-rhfrom
vparfonov:log9396

Conversation

@vparfonov

Copy link
Copy Markdown

backport for: vectordotdev#25251

… soft limit (vectordotdev#25251)

* fix(startup): add --raise-fd-limit CLI flag to raise file descriptor soft limit

Add an opt-in --raise-fd-limit flag (and VECTOR_RAISE_FD_LIMIT env var) that
raises the RLIMIT_NOFILE soft limit to the hard limit at startup, preventing
"Too many open files" errors when monitoring many log files. On macOS, falls
back to kern.maxfilesperproc if the hard limit is too high.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* serialize rlimit tests and reword changelog

Add RLIMIT_MUTEX to prevent concurrent rlimit-mutating tests from
interfering with each other. Reword changelog to avoid triggering
the CI spelling checker.

* move fd-limit raise after logging init and isolate tests in subprocesses

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Enterprise

Run ID: 4897fbe7-469a-439a-8baf-c8796f3f9501

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from cahartma and syedriko June 11, 2026 16:06
@jcantrill

Copy link
Copy Markdown
Member

/approve

@openshift-ci

openshift-ci Bot commented Jun 11, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, vparfonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jun 11, 2026

Copy link
Copy Markdown

@vparfonov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/cluster-logging-operator-e2e f5884e7 link true /test cluster-logging-operator-e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants