[Rust] add the process step for the creation of a custom binary view#8061
Open
rbran wants to merge 1 commit intoVector35:devfrom
Open
[Rust] add the process step for the creation of a custom binary view#8061rbran wants to merge 1 commit intoVector35:devfrom
rbran wants to merge 1 commit intoVector35:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows custom implementations of CustomBinaryView to call
self.*function related toBinaryView.Currently calling something like
add_segmentinside theinitfunction will cause a panic because thecontext.statehad being initialized withCustomViewContextState::Initializedyet, eg minidump does it:binaryninja-api/view/minidump/src/view.rs
Lines 261 to 265 in e1efc28