[TF2] Re-add stun effects for The Sandman (BONK! icon, conc stars, voicelines)#1919
Open
haaksirikko wants to merge 1 commit into
Open
[TF2] Re-add stun effects for The Sandman (BONK! icon, conc stars, voicelines)#1919haaksirikko wants to merge 1 commit into
haaksirikko wants to merge 1 commit into
Conversation
|
Good for adding visual and audio recognition, sometimes I can't really tell if someone got hit by the ball or not. |
haaksirikko
force-pushed
the
sandman-effects
branch
from
6e68bb4 to
e16d5d1
Compare
FlaminSarge
reviewed
Jun 1, 2026
Contributor
FlaminSarge
left a comment
FlaminSarge
left a comment
There was a problem hiding this comment.
Something seems clunky with the way stun flags are being used in general (not from this PR, but in existing logic). Might be worth trying to clean up/streamline?
Also, it might be worth piggybacking off of one of the other flags instead of adding a new flag e.g. TF_STUN_SOUND. That will cause it to appear after a Scout's drink wears off, but you could argue that's thematic.
Comment on lines
-735
to
+741
| int iStunFlags = ( bMax ) ? TF_STUN_SPECIAL_SOUND | TF_STUN_MOVEMENT : TF_STUN_SOUND | TF_STUN_MOVEMENT; | ||
| int iStunFlags = TF_STUN_MOVEMENT | TF_STUN_SOUND | TF_STUN_STUNBALL; | ||
| float flStunAmount = 0.5f; | ||
| float flStunDuration = Max( 2.f, tf_scout_stunball_base_duration.GetFloat() * flLifeTimeRatio ); | ||
| if ( bMax ) | ||
| { | ||
| flStunDuration += 1.0; | ||
| iStunFlags |= TF_STUN_SPECIAL_SOUND; |
Contributor
There was a problem hiding this comment.
Worth noting for future readers that SPECIAL_SOUND fully overrides the regular sound in StunSound, so having both flags here won't be an issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restores the effects (BONK! icon, conc stars, voicelines) of the Sandman that made it iconic without changing the weapon's functionality otherwise.
Adds a new stun flag
TF_STUN_STUNBALLfor this functionality. (unsure if it is the best name for it)Supersedes #984, fixes ValveSoftware/Source-1-Games#4467
Vanilla:
sandman-vanilla.mp4
This PR (attacker):
sandman-fix1.mp4
Victim:
8mb.video-oCL-eRaiWzry.mp4