supported splitting packages

[jxq1997216]

Now write package is supported splitting packages,You can use it like this
package.Write("writePath",maxPackageBytes);

[xPaw]

This needs tests (ideally without writing gigabytes to disk though)

[jxq1997216]

This needs tests (ideally without writing gigabytes to disk though)

Excuse me, may I ask what I need to do?

[xPaw]

Like this: https://github.com/ValveResourceFormat/ValvePak/blob/master/ValvePak/ValvePak.Test/WriteTest.cs

[xPaw]

Remove this loop

[jxq1997216]

This is to delete the subcontracted files produced by previous tasks. I believe that when users reduce the maximum number of bytes and recreate the subcontracted files, the existence of the previous subcontracted files can be very confusing for users

[xPaw]

That's up to them to clean up then, not really our job to arbitrarily loop for 1k files. We only care that the _dir.vpk references correct chunk file which will be overwritten.

[jxq1997216]

That's up to them to clean up then, not really our job to arbitrarily loop for 1k files. We only care that the _dir.vpk references correct chunk file which will be overwritten.

You're right, we shouldn't help users make decisions without authorization

[jxq1997216]

像这样：https://github.com/ValveResourceFormat/ValvePak/blob/master/ValvePak/ValvePak.Test/WriteTest.cs

Okay, let me try something. I haven't written anything similar before

[xPaw]

I don't think this is needed. You can calculate the ArchiveIndex directly in AddFile.

You can look at Valve's packedstore.cpp to see how they handle adding files:

• CPackedStore::AddFile has a bMultiChunk bool.
• They keep track of m_nHighestChunkFileIndex and then increase it if the file offset is higher than m_nWriteChunkSize which defaults to 200 * 1024 * 1024 bytes.

[jxq1997216]

That sounds good,I should go take a look at packdstore.cpp,Can you tell me where it is?

[xPaw]

Search for cstrike15_src

[jxq1997216]

I found it, thank you

[xPaw]

I don't like using maxFileBytes here, we should just have a bool to specify that we want to multi chunk.

This size calculation is also gonna be incorrect if we want to write file hashes.

[xPaw]

We currently have this, but this ideally should be calculated for the chunks:

				// File hashes hash
				var fileHashesMD5 = MD5.HashData([]); // We did not write any file hashes
				writer.Write(fileHashesMD5);

Ref in valve's code: HashAllChunkFiles

[jxq1997216]

We currently have this, but this ideally should be calculated for the chunks:

				// File hashes hash
				var fileHashesMD5 = MD5.HashData([]); // We did not write any file hashes
				writer.Write(fileHashesMD5);

Ref in valve's code: HashAllChunkFiles

Actually, I'm not quite sure how to calculate the hash value here. I think I should first take a look at cstrike15_strc