Added a test to check all robot model parametrizations#505
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #505 +/- ##
==========================================
- Coverage 76.96% 76.66% -0.31%
==========================================
Files 116 116
Lines 6342 6354 +12
Branches 2761 2764 +3
==========================================
- Hits 4881 4871 -10
- Misses 1112 1134 +22
Partials 349 349
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default mode and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 3cb96c9. Configure here.
| URSIM_VERSION: ${{matrix.env.URSIM_VERSION}} | ||
| - name: Upload test results to Codecov | ||
| if: ${{ !cancelled() && steps.build.outcome == 'success' }} | ||
| if: ${{ !cancelled() }} |
There was a problem hiding this comment.
Coverage steps lost !cancelled() guard condition
Low Severity
The install gcovr, gcovr, and Upload coverage reports steps in run_tests previously had if: ${{ !cancelled() && steps.build.outcome == 'success' }}, ensuring coverage was collected even when tests failed. Removing the entire condition (rather than just the now-invalid steps.build.outcome check) means these steps default to success() and won't run on test failure — silently dropping coverage data. The Upload test results step at line 116 correctly kept !cancelled(), making this inconsistency look like an oversight.
Reviewed by Cursor Bugbot for commit 3cb96c9. Configure here.


This PR adds a workflow to check the robot model as reported from the primary interface with the model argument provided to
start_ursim.sh.This also fixes passing ur7e or ur12e to PolyScope 5.
To reduce build resources, this PR splits the integration tests into a "build" stage and two "test" stages utilizing that build. This probably doesn't save any time, but build resources and makes handling a failed build easier.
Note
Medium Risk
Moderate risk because it restructures CI execution and modifies
start_ursim.shmodel normalization for UR7e/UR12e, which could break integration test orchestration or URSim startup if misconfigured.Overview
Splits the integration workflow into a dedicated Ubuntu build job and downstream test jobs by archiving/uploading the CMake
builddirectory and reusing it inrun_tests(and a new check job), reducing repeated compilation.Adds a new CI job to validate robot model parametrizations across many URSim versions/models by running only
PrimaryClientTest.test_robot_typeand reporting coverage with distinct Codecov flags.Fixes UR7e/UR12e handling in
scripts/start_ursim.shso PolyScope 5 strips the trailingewhile PolyScope X keepsUR7e/UR12e, with updated Bats assertions.Introduces
robotTypeFromStringinhelpersand a new GTest that compares the primary interface-reported robot type against theROBOT_MODELenv var mapping (including UR7e→UR5 and UR12e→UR10).Reviewed by Cursor Bugbot for commit 3cb96c9. Bugbot is set up for automated code reviews on this repo. Configure here.