FIX: Change TMP text wrap to supported enum property instead of obsoleted boolean property#2442
Open
ekcoh wants to merge 4 commits into
Open
FIX: Change TMP text wrap to supported enum property instead of obsoleted boolean property#2442ekcoh wants to merge 4 commits into
ekcoh wants to merge 4 commits into
Conversation
…eted boolean property
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
The migration to the enum-based text wrapping property is a good cleanup, though one copy-paste error in the test scripts needs correction.
Additional observations
Assets/QA/Tests/Core Platform Menu/SceneMenu.cs:391(medium) — It looks like a copy-paste typo was introduced here during the refactoring. The placeholder text (ph) has its wrapping mode set a second time, while the input text (txt) is left with default wrapping. This should configuretxtinstead.
🤖 Helpful? 👍/👎
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2442 +/- ##
============================================
+ Coverage 58.58% 79.02% +20.44%
============================================
Files 738 766 +28
Lines 135831 140408 +4577
============================================
+ Hits 79570 110963 +31393
+ Misses 56261 29445 -26816 Flags with carried forward coverage won't be shown. Click here to find out more. |
Pauliusd01
reviewed
Jun 26, 2026
| - Fixed an incorrect ArraysHelper.HaveDuplicateReferences implementation that didn't use its arguments right [ISXB-1792] (https://github.com/Unity-Technologies/InputSystem/pull/2376) | ||
| - Fixed `InputAction.IsPressed`, `WasPressedThisFrame`, and `WasReleasedThisFrame` using a `ButtonControl`'s `pressPoint` when a binding also had an explicit `PressInteraction` with its own `pressPoint`, which could make those APIs disagree with the interaction's press and release behavior. Action-level press APIs now follow the interaction threshold when both are set explicitly. | ||
| - Fixed `IndexOutOfRangeException` in `InputDeviceBuilder` when connecting an HID gamepad whose report descriptor declares a hat switch with Report Size 8 (e.g. ESP32-BLE-Gamepad). The HID layer now anchors the hat's directional sub-controls to the hat's own byte instead of letting the layout system auto-allocate a fresh byte for each [UUM-143659](https://jira.unity3d.com/browse/UUM-143659). | ||
| - Fixed a compilation error with newer versions of TextMesh Pro where text wrapping via boolean property have been deprecated. ISXB-1800. |
Collaborator
There was a problem hiding this comment.
The scene menu is purely internal and not something we ship, I think we don't need a changelog entry
Collaborator
Author
There was a problem hiding this comment.
Good point, I remove it
Pauliusd01
approved these changes
Jun 26, 2026
Pauliusd01
left a comment
Pauliusd01
left a comment
Collaborator
There was a problem hiding this comment.
Didn't really check it live but seemed harmless so lgtm
Collaborator
Author
|
@Pauliusd01 I didn't check it much either, if CI is green across supported versions we should be good I think. |
ritamerkl
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change TMP text wrap to supported enum property instead of obsoleted boolean property
Testing status & QA
Verified it compiles. Need to check it works on min supported versions.
Overall Product Risks
Comments to reviewers
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.