Revert "CHANGE: XRI test ignored as it is causing issues in the CI. I…#2399
Revert "CHANGE: XRI test ignored as it is causing issues in the CI. I…#2399josepmariapujol-unity wants to merge 1 commit intodevelopfrom
Conversation
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
| [Ignore("ISX-2531 - This test is currently ignored as it is causing issues in the CI. It should be re-enabled once the underlying issue is resolved.")] | ||
| public IEnumerator AdddingLatestXRIPackageThrowsNoErrors() | ||
| { | ||
| Application.logMessageReceived += HandleLog; |
There was a problem hiding this comment.
This test re-enables a check that was previously ignored due to CI issues, but it appears to still leak the HandleLog event handler. Since Application.logMessageReceived is a static event, adding a handler on line 43 without a corresponding unsubscription in the TearDown method (or a try-finally block) will cause the handler to persist across subsequent tests in the same run. This can lead to flaky failures or side effects in the rest of the test suite, which is likely the "issue in the CI" mentioned in the original ignore attribute.
Have you considered unsubscribing from this event in the TearDown method to ensure the environment is clean for other tests?
🤖 Helpful? 👍/👎
| [UnityTest] | ||
| [Category("Integration")] | ||
| [Ignore("ISX-2531 - This test is currently ignored as it is causing issues in the CI. It should be re-enabled once the underlying issue is resolved.")] | ||
| public IEnumerator AdddingLatestXRIPackageThrowsNoErrors() |
There was a problem hiding this comment.
There is a minor typo in the method name: "Addding" should be "Adding".
| public IEnumerator AdddingLatestXRIPackageThrowsNoErrors() | |
| public IEnumerator AddingLatestXRIPackageThrowsNoErrors() |
🤖 Helpful? 👍/👎
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2399 +/- ##
===========================================
+ Coverage 77.92% 78.09% +0.17%
===========================================
Files 482 483 +1
Lines 97755 98760 +1005
===========================================
+ Hits 76175 77131 +956
- Misses 21580 21629 +49 Flags with carried forward coverage won't be shown. Click here to find out more.
|
1 participant
…t should be re-enabled once resolved (#2390)"
This reverts commit 0bb75c4.
Currently failing (https://unity-ci.cds.internal.unity3d.com/job/65519130?utm_source=github)