CHANGE: Update asset Actions.inputactions to use UI Toolkit framework #2394
CHANGE: Update asset Actions.inputactions to use UI Toolkit framework #2394josepmariapujol-unity merged 8 commits intodevelopfrom
Conversation
There was a problem hiding this comment.
The review identified a few areas for improvement, primarily concerning localization and editor state management. There is also a minor concern regarding UI implementation stability.
- State Management: Recommended calling
serializedObject.Update()inCreateInspectorGUIto ensure data consistency. - Localization: Migration to UIToolkit has replaced localized strings with hardcoded ones.
- UI Implementation: Noted a dependency on internal UIToolkit selectors which may be fragile.
- Validation: Confirmed correct usage of change event values in one instance.
🤖 Helpful? 👍/👎
Packages/com.unity.inputsystem/InputSystem/Editor/AssetImporter/InputActionImporterEditor.cs
Show resolved
Hide resolved
Packages/com.unity.inputsystem/InputSystem/Editor/AssetImporter/InputActionImporterEditor.cs
Show resolved
Hide resolved
Packages/com.unity.inputsystem/InputSystem/Editor/AssetImporter/InputActionImporterEditor.cs
Show resolved
Hide resolved
Packages/com.unity.inputsystem/InputSystem/Editor/AssetImporter/InputActionImporterEditor.cs
Show resolved
Hide resolved
Explicitly update the SerializedObject in InputActionImporterEditor.
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## develop #2394 +/- ##
===========================================
- Coverage 77.92% 77.85% -0.07%
===========================================
Files 482 482
Lines 97755 97861 +106
===========================================
+ Hits 76175 76191 +16
- Misses 21580 21670 +90 Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/test_plan |
Test Plan
Summary of Changes & Risk AssessmentSummary of ChangesThis PR migrates the Risk Assessment
Test ScenariosFunctional Testing
Regression Testing
Edge Cases
💡 This test plan updates automatically when 🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr |
24.03.2026.-.Unity.457.mp4The IMGUI version seems to have handled scaling better for the button text |
Pauliusd01
left a comment
There was a problem hiding this comment.
LGTM, left only some minor comments about issues with scaling and a nitpick about the text looking slightly different. I think only the scaling issue should be looked at seriously
Packages/com.unity.inputsystem/InputSystem/Editor/AssetImporter/InputActionImporterEditor.cs
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/InputSystem/Editor/AssetImporter/InputActionImporterEditor.cs
Outdated
Show resolved
Hide resolved
K-Tone
left a comment
There was a problem hiding this comment.
All throughout this PR - can we move numbers such as margins, alignment, pads, gaps and sizes into style sheets please? Thanks.
Agree! That has been addessed in the latest commit :) |





Description
This PR is updating the UI for asset
Actions.inputactionsto use UI Toolkit framework.(
RevertandApplybuttons still useIMGUI)Testing status & QA
Manually test buttons and UI expecting same results than before.
Screen.Recording.2026-03-23.at.14.33.05.mov
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Comments to reviewers
Please describe any additional information such as what to focus on, or historical info for the reviewers.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.