KAN-10: Fix Silent Failures in Student Scheduling#232
Open
danieloo0 wants to merge 1 commit into
Open
Conversation
Replaced silent SectioningException catches in StudentSchedulingAction with proper logging to improve visibility of runtime issues while preserving existing control flow.
Contributor
|
What is KAN-10? The listed Jira isn't the official issue-tracking tool for the UniTime project (we use GitHub Issues), and it isn't publicly available. Some description of why the change is needed would be beneficial. Also, I do not think the proposed change would even build, as the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed silent handling of SectioningException in StudentSchedulingAction by adding proper logging instead of empty catch blocks.